dongjoon-hyun commented on a change in pull request #25972:
[SPARK-29300][TESTS] Compare `catalyst` and `avro` module benchmark in JDK8/11
URL: https://github.com/apache/spark/pull/25972#discussion_r329664462
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/SqlBasedBenchmark.scala
##########
@@ -34,6 +35,7 @@ trait SqlBasedBenchmark extends BenchmarkBase with SQLHelper
{
SparkSession.builder()
.master("local[1]")
.appName(this.getClass.getCanonicalName)
+ .config(EXECUTOR_EXTRA_JAVA_OPTIONS, "-XX:+UseParallelGC
-XX:-UseDynamicNumberOfGCThreads")
Review comment:
? Did you run that without `sbt`? I'm using `sbt` and the following is the
result. We already have the proper setting in `SparkBuild.scala`.
<img width="690" alt="sbt_result"
src="https://user-images.githubusercontent.com/9700541/65896522-38c14080-e362-11e9-9b57-f233a9887c8c.png";>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/9700541/65896522-38c14080-e362-11e9-9b57-f233a9887c8c.png"](https://user-images.githubusercontent.com/9700541/65896522-38c14080-e362-11e9-9b57-f233a9887c8c.png"){kind=link}