squito commented on a change in pull request #25779: [SPARK-27468][core] Track
correct storage level and mem/disk usage for RDDs.
URL: https://github.com/apache/spark/pull/25779#discussion_r329745464
##########
File path: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala
##########
@@ -235,13 +230,14 @@ private[spark] class AppStatusListener(
rdd.diskUsed = addDeltaToValue(rdd.diskUsed,
(partition.diskUsed / partition.executors.length) * -1)
partition.update(partition.executors
- .filter(!_.equals(event.executorId)), rdd.storageLevel,
+ .filter(!_.equals(event.executorId)),
addDeltaToValue(partition.memoryUsed,
(partition.memoryUsed / partition.executors.length) * -1),
addDeltaToValue(partition.diskUsed,
(partition.diskUsed / partition.executors.length) * -1))
}
}
+ }
update(rdd, now)
Review comment:
right, it was that part, combined with misreading this part of the old code.
Though it seems like it could be a conditional update, but no change from
before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
