HeartSaVioR edited a comment on issue #25779: [SPARK-27468][core] Track correct storage level and mem/disk usage for RDDs. URL: https://github.com/apache/spark/pull/25779#issuecomment-536796350 We might need to inform about the change of LiveEntity to the patch of #25943 , otherwise we might forget to include it in KVStore snapshot. So according to the javadoc, `BlockManager.reportBlockStatus` is intended to current storage status of a block, which is clear, except the case of `BlockManager.dropFromMemory`. It also receives droppedMemorySize and let master deal with information of both sizes (memory/disk) which is really confusing and doesn't match of the explanation of "block managers report the current mem and disk used by the block". Could we remove the exceptional case as well, or there's technical reason to leave it as it is?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
