turboFei commented on a change in pull request #25797: [SPARK-29043][Core]
Improve the concurrent performance of History Server
URL: https://github.com/apache/spark/pull/25797#discussion_r329845542
##########
File path:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
##########
@@ -561,7 +555,7 @@ private[history] class FsHistoryProvider(conf: SparkConf,
clock: Clock)
.last(newLastScanTime - 1)
.asScala
.toList
- stale.foreach { log =>
+ stale.filterNot(isProcessing(_)).foreach { log =>
Review comment:
yes, I think we do not need filter these logs which is contained in
`processing`.
The scene that log is both in `listing` and `processing` would only happen
when a log has been processed and written to the `listing` but the finally
block(remove it from `processing`)
has not been executed.
But for this case, even if we cleanup these logs, it would has no impaction.
So, I think we don't need filter these logs here.
@vanzin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
