JoshRosen commented on a change in pull request #25953: [SPARK-29244][Core]
Prevent freed page in BytesToBytesMap free again
URL: https://github.com/apache/spark/pull/25953#discussion_r329886389
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/UnsafeFixedWidthAggregationMapSuite.scala
##########
@@ -382,4 +382,50 @@ class UnsafeFixedWidthAggregationMapSuite
}
}
}
+
+ testWithMemoryLeakDetection("SPARK-29244: freed page should not be freed
again") {
Review comment:
Do we still need this somewhat more-end-to-end, multi-threaded test now that
we have the simpler single-threaded test in `BytesToBytesMapSuite`? I confirmed
that the other test covers the one-line change (the test fails without that
change).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
