MaxGekk commented on issue #25988: [SPARK-29313][SQL] Fix failure on writing to 
`noop` in benchmarks
URL: https://github.com/apache/spark/pull/25988#issuecomment-537038694
 
 
   I agree that the save mode for `noop` doesn't matter but for default mode  
https://github.com/apache/spark/blob/c8159c7941f51caf3d420c8ad8599b869fc56a08/sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala#L844
 there is no case currently 
https://github.com/apache/spark/blob/c8159c7941f51caf3d420c8ad8599b869fc56a08/sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala#L270-L287
 . Maybe it should be implemented in more generic way.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to