gengliangwang commented on a change in pull request #25997: [SPARK-29326][SQL]
ANSI store assignment policy: throw exception on casting failure
URL: https://github.com/apache/spark/pull/25997#discussion_r330906601
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
##########
@@ -36,21 +38,23 @@ import org.apache.spark.unsafe.types.UTF8String
/**
* Test suite for data type casting expression [[Cast]].
*/
-class CastSuite extends SparkFunSuite with ExpressionEvalHelper {
+abstract class CastSuiteBase extends SparkFunSuite with ExpressionEvalHelper {
Review comment:
I think we should fully test it for the future development in the new
expression.
For the overflow test cases, we can reduce duplicated code in this way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
