srowen commented on a change in pull request #26003: [SPARK-29320][TESTS] Compare `sql/core` module in JDK8/11 (Part 1) URL: https://github.com/apache/spark/pull/26003#discussion_r331033308
########## File path: sql/core/benchmarks/AggregateBenchmark-jdk11-results.txt ########## @@ -0,0 +1,143 @@ +================================================================================================ +aggregate without grouping +================================================================================================ + +OpenJDK 64-Bit Server VM 11.0.4+11-LTS on Linux 3.10.0-862.3.2.el7.x86_64 +Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz +agg w/o group: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative +------------------------------------------------------------------------------------------------------------------------ +agg w/o group wholestage off 55644 59484 NaN 37.7 26.5 1.0X Review comment: This would suggest only 1 trial was run on this one. Not wrong per se but ideally these benchmarks all run a few iterations. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
