cloud-fan commented on issue #25998: [SPARK-29328][SQL] Fix calculation of mean 
seconds per month
URL: https://github.com/apache/spark/pull/25998#issuecomment-537981669
 
 
   The pgsql code you referred to is interesting. It assumes 30 days per month 
and 365.25 days per year. I think the idea makes sense, days per year doesn't 
have to be 12 * days per month.
   
   That said, I think we should keep assuming 31 days per month in 
`months_between`. For other places that need days per year, I agree that 
365.2425 is more accurate.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to