rdblue commented on a change in pull request #26001: [SPARK-29331][SQL] create
DS v2 Write at physical plan
URL: https://github.com/apache/spark/pull/26001#discussion_r331147347
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriter.scala
##########
@@ -50,7 +50,7 @@ private[kafka010] object KafkaWriter extends Logging {
topic: Option[String] = None): Unit = {
schema.find(_.name == TOPIC_ATTRIBUTE_NAME).getOrElse(
if (topic.isEmpty) {
- throw new AnalysisException(s"topic option required when no " +
+ throw new IllegalArgumentException(s"topic option required when no " +
Review comment:
Should it be SparkException? I think the last time we discussed these, it
wasn't clear what type of exception to use after analysis. Maybe we need new
exception types?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
