yifeih commented on a change in pull request #25823:
[SPARK-28211][Core][Shuffle] Propose Shuffle Driver Components API
URL: https://github.com/apache/spark/pull/25823#discussion_r331281857
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -524,6 +529,15 @@ class SparkContext(config: SparkConf) extends Logging {
executorEnvs ++= _conf.getExecutorEnv
executorEnvs("SPARK_USER") = sparkUser
+ _shuffleDriverComponents =
ShuffleDataIOUtils.loadShuffleDataIO(config).driver()
+ _shuffleDriverComponents.initializeApplication().asScala.foreach { case
(k, v) =>
+ val key = ShuffleDataIOUtils.SHUFFLE_SPARK_CONF_PREFIX + k
+ if (_conf.contains(key)) {
Review comment:
So the consensus is that the plugin overrides anything that the user sets,
and we log a warning whenever that happens?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
