merrily01 commented on a change in pull request #25920: [SPARK-29233][K8S] Add
regex expression checks for executorEnv…
URL: https://github.com/apache/spark/pull/25920#discussion_r331302946
##########
File path:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/KubernetesConfSuite.scala
##########
@@ -44,6 +44,10 @@ class KubernetesConfSuite extends SparkFunSuite {
"customEnvKey2" -> "customEnvValue2")
private val DRIVER_POD = new PodBuilder().build()
private val EXECUTOR_ID = "executor-id"
+ private val EXECUTOR_ENV_VARS = Map(
+ "spark.executorEnv.1executorEnvVars1/var1" -> "executorEnvVars1",
+ "spark.executorEnv.executorEnvVars2*var2" -> "executorEnvVars2",
+ "spark.executorEnv.executorEnvVars3_var3" -> "executorEnvVars3")
Review comment:
@dongjoon-hyun "spark.executorEnv.4executorEnvVars4/var4" ->
"executorEnvVars4" is the same as "spark.executorEnv.1executorEnvVars1/var1"
-> "executorEnvVars1" . BTW, I added two test cases, which I think will prove
that this is only key-constraint.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
