gatorsmile commented on a change in pull request #25938:
[SPARK-29203][SQL][TESTS][2.4] Reduce shuffle partitions in SQLQueryTestSuite
URL: https://github.com/apache/spark/pull/25938#discussion_r331313246
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -98,6 +100,10 @@ class SQLQueryTestSuite extends QueryTest with
SharedSQLContext {
private val inputFilePath = new File(baseResourcePath,
"inputs").getAbsolutePath
private val goldenFilePath = new File(baseResourcePath,
"results").getAbsolutePath
+ override def sparkConf: SparkConf = super.sparkConf
Review comment:
This should be protected, right? In the parent trait SharedSparkSession, it
is protected.
```
protected override def sparkConf ....
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
