HyukjinKwon commented on a change in pull request #26013: [SPARK-29347][SQL]
Add JSON serialization for external Rows
URL: https://github.com/apache/spark/pull/26013#discussion_r331384789
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/Row.scala
##########
@@ -501,4 +513,88 @@ trait Row extends Serializable {
private def getAnyValAs[T <: AnyVal](i: Int): T =
if (isNullAt(i)) throw new NullPointerException(s"Value at index $i is
null")
else getAs[T](i)
+
+ /** The compact JSON representation of this row. */
+ def json: String = compact(jsonValue)
+
+ /** The pretty (i.e. indented) JSON representation of this row. */
+ def prettyJson: String = pretty(render(jsonValue))
+
+ /**
+ * JSON representation of the row.
+ *
+ * Note that this only supports the data types that are also supported by
+ * [[org.apache.spark.sql.catalyst.encoders.RowEncoder]].
+ *
+ * @return the JSON representation of the row.
+ */
+ private[sql] def jsonValue: JValue = {
+ require(schema != null, "JSON serialization requires a non-null schema.")
+
+ lazy val timeZone = TimeZone.getTimeZone(SQLConf.get.sessionLocalTimeZone)
+ lazy val dateFormatter = DateFormatter.apply(timeZone.toZoneId)
+ lazy val timestampFormatter = TimestampFormatter.apply(timeZone.toZoneId)
+
+ // Convert an iterator of values to a json array
+ def iteratorToJsonArray(iterator: Iterator[_], elementType: DataType):
JArray = {
+ JArray(iterator.map(toJson(_, elementType)).toList)
+ }
+
+ // Convert a value to json.
+ def toJson(value: Any, dataType: DataType): JValue = (value, dataType)
match {
Review comment:
@hvanhovell, how about reusing `JacksonGenerator` in our JSON datasource?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
