HeartSaVioR commented on a change in pull request #25943:
[WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for
(SQL)AppStatusListener
URL: https://github.com/apache/spark/pull/25943#discussion_r331410385
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListener.scala
##########
@@ -67,6 +68,27 @@ class SQLAppStatusListener(
}
}
+ // visible for tests
+ private[spark] def recoverLiveEntities(): Unit = {
+ if (!live) {
+ kvstore.view(classOf[SQLExecutionUIData])
+ // null metricValues potentially indicates a live SQLExecutionUIData
Review comment:
Is it exhaustive? or there are some cases we can't handle? Is there any way
to make this deterministic?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
