rdblue commented on a change in pull request #26006: [SPARK-29279][SQL] Merge
SHOW NAMESPACES and SHOW DATABASES code path
URL: https://github.com/apache/spark/pull/26006#discussion_r331658641
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/LookupCatalog.scala
##########
@@ -102,7 +102,7 @@ private[sql] trait LookupCatalog extends Logging {
}
}
- type CurrentCatalogAndNamespace = (CatalogPlugin, Seq[String])
+ type CurrentCatalogAndNamespace = (CatalogPlugin, Option[Seq[String]])
Review comment:
When I see this extractor/type name, it sounds like it should always return
the current catalog. What about just naming this `CatalogAndNamespace` and
document that the current catalog may be returned?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
