squito commented on a change in pull request #25779: [SPARK-27468][core] Track
correct storage level of RDDs and partitions.
URL: https://github.com/apache/spark/pull/25779#discussion_r331691141
##########
File path: core/src/main/scala/org/apache/spark/status/LiveEntity.scala
##########
@@ -520,27 +521,28 @@ private class LiveRDDDistribution(exec: LiveExecutor) {
}
-private class LiveRDD(val info: RDDInfo) extends LiveEntity {
+/**
+ * Tracker for data related to a persisted RDD. Note the storage level is kept
immutable here,
+ * following the current behavior of `RDD.persist()`, even though it is
mutable in the `RDDInfo`
+ * structure.
+ */
Review comment:
A stage may have been submitted before the RDD was persisted at all, then
another stage submitted after the RDD is persisted, so its not actually
immutable. You wouldn't properly capture that here.
(probably not the optimal thing for the user to do, but I've seen weirder
things ...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
