vanzin commented on a change in pull request #25779: [SPARK-27468][core] Track 
correct storage level of RDDs and partitions. 
URL: https://github.com/apache/spark/pull/25779#discussion_r331701174
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/status/LiveEntity.scala
 ##########
 @@ -520,27 +521,28 @@ private class LiveRDDDistribution(exec: LiveExecutor) {
 
 }
 
-private class LiveRDD(val info: RDDInfo) extends LiveEntity {
+/**
+ * Tracker for data related to a persisted RDD. Note the storage level is kept 
immutable here,
+ * following the current behavior of `RDD.persist()`, even though it is 
mutable in the `RDDInfo`
+ * structure.
+ */
 
 Review comment:
   Actually that works fine, because the listener does not track RDDs that are 
not persisted; so there wouldn't be a live RDD for the first stage in your 
example; it would be created when the second stage is submitted, and at that 
point the storage level cannot be changed further.
   
   I'll update the comment (maybe even add a unit test).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to