imback82 commented on a change in pull request #26006: [SPARK-29279][SQL] Merge 
SHOW NAMESPACES and SHOW DATABASES code path
URL: https://github.com/apache/spark/pull/26006#discussion_r331732193
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
 ##########
 @@ -2694,7 +2694,7 @@ class SQLQuerySuite extends QueryTest with 
SharedSparkSession {
     sparkContext.addSparkListener(listener)
     try {
       // Execute the command.
-      sql("show databases").head()
+      sql("EXPLAIN show databases").head()
 
 Review comment:
   This is because the new `*Exec` classes extends `LeafExecNode`, which runs a 
job when `executeCollect` is called. If we need to keep the behavior same 
(#17027), we can reuse `ExecutedCommandExec` along with `RunnableCommand` or 
introduce new physical operator for these commands that don't require running a 
job. @cloud-fan, looks like you reviewed #17027 back in 2017. :) This is still 
a hard requirement right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to