dongjoon-hyun commented on a change in pull request #26010: [SPARK-29342][SQL]
Make casting of string values to intervals case insensitive
URL: https://github.com/apache/spark/pull/26010#discussion_r331766223
##########
File path:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/CalendarInterval.java
##########
@@ -69,7 +70,7 @@ private static long toLong(String s) {
/**
* Convert a string to CalendarInterval. Return null if the input string is
not a valid interval.
- * This method is case-sensitive and all characters in the input string
should be in lower case.
+ * This method is case-insensitive.
Review comment:
This change the description without changing the function body. This means
the previous function descriptions wrong. However, for example, the function
body still has case-sensitive function like `s.equals("interval")`. For me, the
previous function description is correct and new one is incorrect. ~Let's
recover this comment change.~ Or, could you change the remaining part?
BTW, this discussion means the lack of test coverage for this part. Could
you add a test coverage for that code path?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
