MaxGekk commented on a change in pull request #26010: [SPARK-29342][SQL] Make
casting of string values to intervals case insensitive
URL: https://github.com/apache/spark/pull/26010#discussion_r331772293
##########
File path:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/CalendarInterval.java
##########
@@ -93,12 +94,13 @@ public static CalendarInterval fromString(String s) {
}
/**
- * Convert a string to CalendarInterval. Unlike fromString, this method is
case-insensitive and
- * will throw IllegalArgumentException when the input string is not a valid
interval.
+ * Convert a string to CalendarInterval. Unlike fromString, this method can
handle
+ * strings without the `interval` prefix and throws IllegalArgumentException
+ * when the input string is not a valid interval.
*
* @throws IllegalArgumentException if the string is not a valid internal.
*/
- public static CalendarInterval fromCaseInsensitiveString(String s) {
+ public static CalendarInterval fromStringWithOptionalPrefix(String s) {
Review comment:
ok. I will revert this renaming.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
