srowen commented on issue #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2 URL: https://github.com/apache/spark/pull/25984#issuecomment-538754108 Does this `-am` change affect the output of the Hadoop 2.7 deps? I agree it sounds like this is a better way to identify what JARs are in the published binary release, as that is what the licenses must reflect. Is it possible to build the Hadoop 3.2 release and spot check whether the changes are correct -- removed deps really don't end up in the jars/ folder, and new deps do? If there are real changes to 3.2 or 2.7 deps, we need to also reevaluate what is in our LICENSE-binary / license-binary/ files to ensure we have the right statements.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
