MaxGekk commented on a change in pull request #26034: [SPARK-29364][SQL] Return
an interval from date subtract according to SQL standard
URL: https://github.com/apache/spark/pull/26034#discussion_r331808331
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/DateExpressionsSuite.scala
##########
@@ -836,7 +836,7 @@ class DateExpressionsSuite extends SparkFunSuite with
ExpressionEvalHelper {
}
}
- test("datediff") {
+ test("datediff returns an integer") {
Review comment:
I think it would be better to add asserts to check this assumption otherwise
if defaults for the SQL config will be changed in the future, this test will
not check default behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
