HeartSaVioR commented on issue #26039: [SPARK-29366][SQL] Subqueries created 
for DPP are not printed in EXPLAIN FORMATTED
URL: https://github.com/apache/spark/pull/26039#issuecomment-538839655
 
 
   Just leaving general comments, as I'm not familiar with this change:
   
   > The subquery expressions introduced by DPP are not printed in the newer 
explain command.
   > This PR fixes the code that computes the list of subqueries in the plan.
   
   > Without the fix, the subqueries are printed in the explain plan.
   
   Sounds like contradiction: former says subquery expressions are "not" 
printed for now, and latter says subqueries are printed without the fix.
   
   > Yes. the explain output will be different.
   
   Shall we provide example query and actual change of explain string (before 
applying vs after applying)? It would be helpful to determine the effect of the 
patch visually.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to