cloud-fan commented on a change in pull request #26013: [SPARK-29347][SQL] Add
JSON serialization for external Rows
URL: https://github.com/apache/spark/pull/26013#discussion_r331965588
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -155,7 +155,12 @@ object SQLConf {
confGetter.get()()
}
} else {
- confGetter.get()()
+ val conf = existingConf.get()
+ if (conf != null) {
Review comment:
seems like this is a new feature for testing: now we can overwrite the
current SQLConf by calling `SQLConf.withExistingConf`.
This might be a good idea, but this is not how we handle this case in the
current codebase. If you look at `ParquetFilterSuite`, we can set the current
SQLConf in `beforeAll`, and unset it in `afterAll`. How about we follow the
existing solution and open a new PR for this new feature?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
