Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/4233#discussion_r23888056
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
@@ -68,6 +79,65 @@ class LogisticRegressionModel (
case None => score
}
}
+
+ override def save(sc: SparkContext, path: String): Unit = {
+ val sqlContext = new SQLContext(sc)
+ import sqlContext._
--- End diff --
I tried that, and it fails to compile. (I tried removed sqlContext from
save(), as well as having it be an implicit val without the import. Neither
worked.) Is there another import I need?
```
[error]
/Users/josephkb/spark/mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala:89:
type mismatch;
[error] found :
org.apache.spark.rdd.RDD[org.apache.spark.mllib.classification.LogisticRegressionModel.Metadata]
[error] required: org.apache.spark.sql.DataFrame
[error] Error occurred in an application involving default arguments.
[error] val metadataRDD: DataFrame = sc.parallelize(Seq(metadata))
[error] ^
[error]
/Users/josephkb/spark/mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala:94:
type mismatch;
[error] found :
org.apache.spark.rdd.RDD[org.apache.spark.mllib.classification.LogisticRegressionModel.Data]
[error] required: org.apache.spark.sql.DataFrame
[error] Error occurred in an application involving default arguments.
[error] val dataRDD: DataFrame = sc.parallelize(Seq(data))
[error] ^
[error] two errors found
[error] (mllib/compile:compile) Compilation failed
```
It may not be an issue though, with the other change you suggested below.
I'll see.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
