cloud-fan commented on a change in pull request #26039: [SPARK-29366][SQL]
Subqueries created for DPP are not printed in EXPLAIN FORMATTED
URL: https://github.com/apache/spark/pull/26039#discussion_r332360235
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExplainUtils.scala
##########
@@ -199,8 +199,8 @@ object ExplainUtils {
case s: BaseSubqueryExec =>
subqueries += ((p, e, s))
getSubqueries(s, subqueries)
+ case _ =>
Review comment:
> We need the collect to traverse the expression tree
hmm, can we use `foreach` to traverse the expression tree? We have
`TreeNode.foreach`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
