dongjoon-hyun commented on a change in pull request #26073:
[SPARK-29416][CORE][ML][SQL][MESOS] Use .sameElements to compare arrays,
instead of .deep (gone in 2.13)
URL: https://github.com/apache/spark/pull/26073#discussion_r333160247
##########
File path:
mllib/src/test/scala/org/apache/spark/mllib/feature/ChiSqSelectorSuite.scala
##########
@@ -189,6 +189,6 @@ object ChiSqSelectorSuite extends SparkFunSuite {
}
def checkEqual(a: ChiSqSelectorModel, b: ChiSqSelectorModel): Unit = {
- assert(a.selectedFeatures.deep == b.selectedFeatures.deep)
+ assert(a.selectedFeatures.sameElements(b.selectedFeatures)
Review comment:
Hi, @srowen . This is a compile error~
```
[error]
/Users/dongjoon/PRS/PR-26073/mllib/src/test/scala/org/apache/spark/mllib/feature/ChiSqSelectorSuite.scala:193:
')' expected but '}' found.
[error] }
[error] ^
[error] one error found
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
