huaxingao commented on a change in pull request #26057: 
[SPARK-29377][PYTHON][ML] Parity between Scala ML tuning and Python ML tuning
URL: https://github.com/apache/spark/pull/26057#discussion_r333230868
 
 

 ##########
 File path: python/pyspark/ml/tuning.py
 ##########
 @@ -199,7 +181,25 @@ def _to_java_impl(self):
         return java_estimator, java_epms, java_evaluator
 
 
-class CrossValidator(Estimator, ValidatorParams, HasParallelism, 
HasCollectSubModels,
+class _CrossValidatorParams(_ValidatorParams):
 
 Review comment:
   I don't think adding leading underscore will affect users to extend these 
classes. The single leading underscore before a class name is only a weak 
indicator for internal usage. It doesn't enforce privacy. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to