cloud-fan commented on a change in pull request #25295: [SPARK-28560][SQL]
Optimize shuffle reader to local shuffle reader when smj converted to bhj in
adaptive execution
URL: https://github.com/apache/spark/pull/25295#discussion_r333940553
##########
File path: core/src/main/scala/org/apache/spark/shuffle/ShuffleManager.scala
##########
@@ -54,6 +54,19 @@ private[spark] trait ShuffleManager {
context: TaskContext,
metrics: ShuffleReadMetricsReporter): ShuffleReader[K, C]
+ /**
+ * Get a reader for a range of reduce partitions (startPartition to
endPartition-1, inclusive) to
+ * read from mapId.
+ * Called on executors by reduce tasks.
+ */
+ def getMapReader[K, C](
+ handle: ShuffleHandle,
+ startPartition: Int,
+ endPartition: Int,
Review comment:
now the local shuffle reader always read all the shuffle blocks of one
mapper. Let's add the above 2 parameters later when we going to use them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
