Clarkkkkk commented on a change in pull request #26090: [SPARK-29302]Fix
writing file collision in dynamic partition overwrite mode within speculative
execution
URL: https://github.com/apache/spark/pull/26090#discussion_r333954828
##########
File path:
core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala
##########
@@ -89,7 +92,7 @@ class HadoopMapReduceCommitProtocol(
* The staging directory of this write job. Spark uses it to deal with files
with absolute output
* path, or writing data into partitioned directory with
dynamicPartitionOverwrite=true.
*/
- private def stagingDir = new Path(path, ".spark-staging-" + jobId)
+ private def stagingDir = new Path(stagingPath.getOrElse(path))
Review comment:
You are right, stagingDir cannot be used here, as it might get deleted
during abortJob.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
