skonto commented on a change in pull request #25609: [SPARK-28896][K8S] Support 
defining HADOOP_CONF_DIR and config map at the same time
URL: https://github.com/apache/spark/pull/25609#discussion_r333990738
 
 

 ##########
 File path: 
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/HadoopConfDriverFeatureStepSuite.scala
 ##########
 @@ -62,6 +65,17 @@ class HadoopConfDriverFeatureStepSuite extends 
SparkFunSuite {
     assert(hadoopConfMap.getData().keySet().asScala === confFiles)
   }
 
+  test("using hadoop config map ahead of conf dir if both defined") {
+    val sparkConf = new SparkConfWithEnv(Map(ENV_HADOOP_CONF_DIR -> 
confDir.getAbsolutePath()))
+      .set(Config.KUBERNETES_HADOOP_CONF_CONFIG_MAP, "testConfigMap")
+
+    val conf = KubernetesTestConf.createDriverConf(sparkConf = sparkConf)
 
 Review comment:
   nit: remove space

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to