dongjoon-hyun commented on a change in pull request #26094: [SPARK-29442][SQL]
Set `default` mode should override the existing mode
URL: https://github.com/apache/spark/pull/26094#discussion_r334109659
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
##########
@@ -2203,4 +2203,12 @@ class DataFrameSuite extends QueryTest with
SharedSparkSession {
|*(1) Range (0, 10, step=1, splits=2)""".stripMargin))
}
}
+
+ test("SPARK-29442 Set `default` mode should override the existing mode") {
+ val df = Seq(Tuple1(1)).toDF()
+ val writer = df.write.mode("overwrite").mode("default")
+ val modeField =
classOf[DataFrameWriter[Tuple1[Int]]].getDeclaredField("mode")
+ modeField.setAccessible(true)
+ assert(SaveMode.ErrorIfExists ===
modeField.get(writer).asInstanceOf[SaveMode])
Review comment:
If we don't test all values, it will be the same. And, we don't need to test
for all values for this logic testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
