squito commented on a change in pull request #26058: [SPARK-10614][core] Add
monotonic time to Clock interface.
URL: https://github.com/apache/spark/pull/26058#discussion_r334114942
##########
File path: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala
##########
@@ -288,7 +288,7 @@ private[spark] class ExecutorAllocationManager(
}
// Update executor target number only after initializing flag is unset
- updateAndSyncNumExecutorsTarget(clock.getTimeMillis())
+ updateAndSyncNumExecutorsTarget(clock.nanoTime())
Review comment:
this is a good discussion -- its really easy to get confused about the
details here, especially as some googling can take you to old info. Worth
including a bit of this on the doc for `SystemClock.nanoTime()`? Maybe at
least just noting that this is dependable across cores as long as its Java7+.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
