zsxwing commented on issue #25998: [SPARK-29328][SQL] Fix calculation of mean seconds per month URL: https://github.com/apache/spark/pull/25998#issuecomment-541290266 I took a look at this one. The change is incorrect. Both `GroupStateImpl` and `EventTimeWatermark` pick up 31 days intentionally. Please see the discussion here: https://github.com/apache/spark/pull/16304#discussion_r92753590 This just reminds me that we don't have any document or test for this behavior.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
