dongjoon-hyun commented on a change in pull request #26071: [SPARK-29412][SQL]
refine the document of v2 session catalog config
URL: https://github.com/apache/spark/pull/26071#discussion_r334256366
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2DataFrameSessionCatalogSuite.scala
##########
@@ -144,13 +144,13 @@ private [connector] trait SessionCatalogTest[T <: Table,
Catalog <: TestV2Sessio
protected val catalogClassName: String =
classOf[InMemoryTableSessionCatalog].getName
before {
- spark.conf.set(V2_SESSION_CATALOG.key, catalogClassName)
+ spark.conf.set(V2_SESSION_CATALOG_IMPLEMENTATION.key, catalogClassName)
}
override def afterEach(): Unit = {
super.afterEach()
catalog("session").asInstanceOf[Catalog].clearTables()
Review comment:
This seems to be last remaining instance.
```scala
- catalog("session").asInstanceOf[Catalog].clearTables()
+ catalog(SESSION_CATALOG_NAME).asInstanceOf[Catalog].clearTables()
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
