viirya commented on a change in pull request #26094:
[SPARK-29442][SQL][PYSPARK] Set `default` mode should override the existing mode
URL: https://github.com/apache/spark/pull/26094#discussion_r334262074
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala
##########
@@ -77,7 +77,7 @@ final class DataFrameWriter[T] private[sql](ds: Dataset[T]) {
* <li>`overwrite`: overwrite the existing data.</li>
* <li>`append`: append the data.</li>
* <li>`ignore`: ignore the operation (i.e. no-op).</li>
- * <li>`error` or `errorifexists`: default option, throw an exception at
runtime.</li>
+ * <li>`error`, `errorifexists`, or `default`: default option, throw an
exception at runtime.</li>
Review comment:
actually, I think it is a bit weird to give a "default" option explicitly.
I'd tend to remove "default" option, if possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
