Ngone51 commented on a change in pull request #25943:
[WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for
(SQL)AppStatusListener
URL: https://github.com/apache/spark/pull/25943#discussion_r334279604
##########
File path: core/src/main/scala/org/apache/spark/status/api/v1/api.scala
##########
@@ -192,14 +194,34 @@ class RDDDataDistribution private[spark](
@JsonDeserialize(contentAs = classOf[JLong])
val onHeapMemoryRemaining: Option[Long],
@JsonDeserialize(contentAs = classOf[JLong])
- val offHeapMemoryRemaining: Option[Long])
+ val offHeapMemoryRemaining: Option[Long]) {
+
+ def toLiveRDDDistribution(executors: scala.collection.Map[String,
LiveExecutor])
+ : LiveRDDDistribution = {
Review comment:
Is this necessary ? Seems we've already has `private[spark]` scope for
`RDDDataDistribution` and other objects which has toLiveXXX methods in
`storeTypes`. So, those objects can't be constructed out of spark and these
toLiveXXX methods won't be accessible, either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
