cloud-fan commented on a change in pull request #26071: [SPARK-29412][SQL]
refine the document of v2 session catalog config
URL: https://github.com/apache/spark/pull/26071#discussion_r334413116
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1976,11 +1977,14 @@ object SQLConf {
.stringConf
.createOptional
- val V2_SESSION_CATALOG = buildConf("spark.sql.catalog.session")
- .doc("A catalog implementation that will be used in place of the Spark
built-in session " +
- "catalog for v2 operations. The implementation may extend
`CatalogExtension` to be " +
- "passed the Spark built-in session catalog, so that it may delegate
calls to the " +
- "built-in session catalog.")
+ val V2_SESSION_CATALOG_IMPLEMENTATION =
+ buildConf(s"spark.sql.catalog.$SESSION_CATALOG_NAME")
+ .doc("A catalog implementation that will be used as the v2 interface to
Spark's built-in " +
+ s"v1 catalog: $SESSION_CATALOG_NAME. This catalog shares its
identifier namespace with " +
+ s"the $SESSION_CATALOG_NAME and must be consistent with it; for
example, if a table can " +
+ s"be loaded by the $SESSION_CATALOG_NAME, this catalog must also
return the table " +
+ s"metadata. To delegate operations to the $SESSION_CATALOG_NAME,
implementations can " +
+ "extend 'CatalogExtension'.")
Review comment:
It must be a v2 interface, but we can't fully control how it is implemented.
We expect it to delegate to the SESSION_CATALOG_NAME, but there is no way to
guarantee it.
If the implementation doesn't delegate, then the behavior is undefined.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
