igorcalabria commented on issue #26093: [SPARK-27812][K8s] Bump client version 
URL: https://github.com/apache/spark/pull/26093#issuecomment-541688656
 
 
   > @igorcalabria . The following claims is not matched with your PR 
description.
   > 
   > > Standard kubernetes tests should validate this patch.
   > 
   > Please describe how to test this for the following for the reviewer. 
(Technically, this PR need a test case for that. Or, at least, manual testing 
process should be described in the PR description and should be the commit log.)
   > 
   > > https://issues.apache.org/jira/browse/SPARK-27812
   > > https://issues.apache.org/jira/browse/SPARK-27927
   
   @dongjoon-hyun A manual test is described above by @ifilonenko. If you want, 
I could add an integration test for this specific case. I skipped it because 
other PRs updating kubernetes-client version didn't add any tests and the 
README in `kubernetes/integration-tests` states that the framework is under 
review and subject to major changes

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to