imback82 commented on issue #26120: [SPARK-29014][SQL] DataSourceV2: Fix current/default catalog usage URL: https://github.com/apache/spark/pull/26120#issuecomment-541990194 > I think this should also make the default catalog and the session catalog private in CatalogManager, to ensure that the _only_ catalog accessed from rules is the current catalog. If the default catalog or session catalog is the current catalog, they can (and should) be accessed by getting the current catalog. The default and session catalogs should be internal to CatalogManager. OK. There are few places where default catalog / session catalog is accessed directly, for example, `CatalogObjectIdentifier`, which is used in many places. I checked few of them, and they can be updated to use just current catalog (along with `isSessionCatalog` check). I will try your suggestion. Thanks @rdblue.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
