dongjoon-hyun commented on a change in pull request #26115:
[SPARK-29469][Shuffle] Avoid retries by RetryingBlockFetcher when
ExternalBlockStoreClient is closed
URL: https://github.com/apache/spark/pull/26115#discussion_r334742591
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockStoreClient.java
##########
@@ -102,9 +102,14 @@ public void fetchBlocks(
try {
RetryingBlockFetcher.BlockFetchStarter blockFetchStarter =
(blockIds1, listener1) -> {
- TransportClient client = clientFactory.createClient(host, port);
- new OneForOneBlockFetcher(client, appId, execId,
- blockIds1, listener1, conf, downloadFileManager).start();
+ // Unless this client is closed.
+ if (clientFactory != null) {
+ TransportClient client = clientFactory.createClient(host, port);
+ new OneForOneBlockFetcher(client, appId, execId,
+ blockIds1, listener1, conf, downloadFileManager).start();
+ } else {
+ logger.warn("This client was closed. Skipping further block
fetch retries.");
Review comment:
Do we need to use `WARN` level? It looks a little high.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
