Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/3486#discussion_r23938653 --- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala --- @@ -382,7 +382,8 @@ private[spark] object JsonProtocol { def executorInfoToJson(executorInfo: ExecutorInfo): JValue = { ("Host" -> executorInfo.executorHost) ~ - ("Total Cores" -> executorInfo.totalCores) + ("Total Cores" -> executorInfo.totalCores) ~ + ("Log Urls" -> mapToJson(executorInfo.logUrlMap)) --- End diff -- should this use `Utils.jsonOption` per the comment at the top of `JsonProtocol` when adding new fields? Also I guess there should be a backward compatibility test case added to `JsonProtocolSuite`
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org