imatiach-msft commented on issue #25926: [SPARK-9612][ML] Add instance weight support for GBTs URL: https://github.com/apache/spark/pull/25926#issuecomment-542276668 @zhengruifeng I see, it seems a bit confusing to have a lot of references to error as both weighted and unweighted inside the same function - for example I would prefer to only checkpoint weighted error, and computeError function doesn't suggest anything in the name about it specifically making the error weighted - but as long as we have good documentation and variable names in the code to help distinguish which variable is for what I think it should be fine
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
