erikerlandson commented on a change in pull request #25870: [SPARK-27936][K8S]
support python deps
URL: https://github.com/apache/spark/pull/25870#discussion_r335131121
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala
##########
@@ -259,12 +259,19 @@ private[spark] object KubernetesUtils extends Logging {
isLocalDependency(Utils.resolveURI(resource))
}
- def renameMainAppResource(resource: String, conf: SparkConf): String = {
+ def renameMainAppResource(
+ resource: String,
+ conf: Option[SparkConf] = None,
+ isJava: Boolean = true): String = {
if (isLocalAndResolvable(resource)) {
- SparkLauncher.NO_RESOURCE
+ if (isJava) {
Review comment:
@holdenk does the java loading explaination work for you:
https://github.com/apache/spark/pull/25870#issuecomment-541001902
To confirm - the timing of the java loading is to ensure java code can
execute when its needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
