Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4067#discussion_r23950681
--- Diff: core/src/main/scala/org/apache/spark/CacheManager.scala ---
@@ -47,9 +49,13 @@ private[spark] class CacheManager(blockManager:
BlockManager) extends Logging {
val inputMetrics = blockResult.inputMetrics
val existingMetrics = context.taskMetrics
.getInputMetricsForReadMethod(inputMetrics.readMethod)
- existingMetrics.addBytesRead(inputMetrics.bytesRead)
+ existingMetrics.incBytesRead(inputMetrics.bytesRead)
- new InterruptibleIterator(context,
blockResult.data.asInstanceOf[Iterator[T]])
+ val iter = blockResult.data.asInstanceOf[Iterator[T]]
+ new InterruptibleIterator(context,
AfterNextInterceptingIterator(iter, (next: T) => {
+ existingMetrics.incRecordsRead(1)
--- End diff --
And yes, every time we add some sort of iterator like this, we do a lot of
performance benchmarks. IterruptableIterator was added long before the project
is an official ASF project, and even back then we tested performance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
