dongjoon-hyun commented on a change in pull request #26123: [SPARK-27259][CORE]
Allow setting -1 as split size for InputFileBlock
URL: https://github.com/apache/spark/pull/26123#discussion_r335249431
##########
File path: core/src/main/scala/org/apache/spark/rdd/InputFileBlockHolder.scala
##########
@@ -76,7 +76,6 @@ private[spark] object InputFileBlockHolder {
def set(filePath: String, startOffset: Long, length: Long): Unit = {
require(filePath != null, "filePath cannot be null")
require(startOffset >= 0, s"startOffset ($startOffset) cannot be negative")
- require(length >= 0, s"length ($length) cannot be negative")
Review comment:
Yes. Please update the PR with `length >= -1`. For the message, that message
looks okay. Then, probably, it's okay.
> Yes, I can modify the validation statement to be length >= -1. In that
case, what can be a good message? Maybe - "length ($length) cannot be smaller
than -1"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
