cloud-fan commented on a change in pull request #26040: [SPARK-9853][Core]
Optimize shuffle fetch of continuous partition IDs
URL: https://github.com/apache/spark/pull/26040#discussion_r335491096
##########
File path:
core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockResolver.scala
##########
@@ -202,20 +210,21 @@ private[spark] class IndexShuffleBlockResolver(
// class of issue from re-occurring in the future which is why they are
left here even though
// SPARK-22982 is fixed.
val channel = Files.newByteChannel(indexFile.toPath)
- channel.position(blockId.reduceId * 8L)
+ channel.position(startReduceId * 8L)
val in = new DataInputStream(Channels.newInputStream(channel))
try {
val offset = in.readLong()
+ channel.position(endReduceId * 8L)
val nextOffset = in.readLong()
Review comment:
nit: we probably should rename "offset", "nextOffset" to "startOffset",
"endOffset"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
