srowen commented on a change in pull request #26135: [SPARK-29489][ML][PySpark]
ml.evaluation support log-loss
URL: https://github.com/apache/spark/pull/26135#discussion_r335590799
##########
File path:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/MulticlassMetrics.scala
##########
@@ -23,33 +23,35 @@ import scala.collection.mutable
import org.apache.spark.annotation.Since
import org.apache.spark.mllib.linalg.{Matrices, Matrix}
import org.apache.spark.rdd.RDD
-import org.apache.spark.sql.{DataFrame, Row}
+import org.apache.spark.sql.DataFrame
/**
* Evaluator for multiclass classification.
*
- * @param predictionAndLabels an RDD of (prediction, label, weight) or
- * (prediction, label) tuples.
+ * @param predictionAndLabels an RDD of (prediction, label, weight,
probability) or
Review comment:
This is my only concern, that you have to plumb through a probability just
to support this, but it's not out of the question.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
