vanzin commented on a change in pull request #25670: [SPARK-28869][CORE] Roll
over event log files
URL: https://github.com/apache/spark/pull/25670#discussion_r335620449
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -180,16 +180,18 @@ package object config {
ConfigBuilder("spark.eventLog.longForm.enabled").booleanConf.createWithDefault(false)
private[spark] val EVENT_LOG_ENABLE_ROLLING =
- ConfigBuilder("spark.eventLog.logRolling.enabled")
+ ConfigBuilder("spark.eventLog.rolling.enabled")
.doc("Whether rolling over event log files is enabled. If set to true,
it cuts down " +
"each event log file to the configured size.")
.booleanConf
.createWithDefault(false)
- private[spark] val EVENT_LOG_ROLLED_LOG_MAX_FILE_SIZE =
- ConfigBuilder("spark.eventLog.logRolling.maxFileSize")
+ private[spark] val EVENT_LOG_ROLLING_MAX_FILE_SIZE =
+ ConfigBuilder("spark.eventLog.rolling.maxFileSize")
.doc("The max size of event log file to be rolled over.")
.bytesConf(ByteUnit.BYTE)
+ .checkValue(_ >= (1024 * 1024 * 10), "Max file size of event log should
be configured to" +
Review comment:
`ByteUnit.MiB.toBytes(10)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
